Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvements to heroku log drain #8559

Merged
merged 12 commits into from
May 15, 2024
Merged

improvements to heroku log drain #8559

merged 12 commits into from
May 15, 2024

Conversation

Vadman97
Copy link
Member

@Vadman97 Vadman97 commented May 14, 2024

Summary

  • Fixes documentation for heroku log drain
  • Fixes implementation for matching heroku log drain token -> project ID.

Testing the heroku log drain implementation locally was impossible given valid TLS termination for a local endpoint was necessary, and even ngrok with TLS mode seemed to be garbling the data.

How did you test this change?

docs preview

Screenshot from 2024-05-14 14-56-46

Are there any deployment considerations?

no

Does this work require review from our design team?

no

Copy link

changeset-bot bot commented May 14, 2024

⚠️ No Changeset found

Latest commit: bcb27b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

backend/otel/otel.go Fixed Show fixed Hide fixed
@Vadman97 Vadman97 requested review from a team and ccschmitz and removed request for a team May 14, 2024 21:59
@Vadman97 Vadman97 marked this pull request as ready for review May 14, 2024 21:59
Copy link
Contributor

@ccschmitz ccschmitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vadman97 Vadman97 merged commit 74843b0 into main May 15, 2024
30 checks passed
@Vadman97 Vadman97 deleted the vadim/fix-heroku branch May 15, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants