-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvements to heroku log drain #8559
Conversation
|
0cafe36
to
23c3829
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
Testing the heroku log drain implementation locally was impossible given valid TLS termination for a local endpoint was necessary, and even ngrok with TLS mode seemed to be garbling the data.
How did you test this change?
docs preview
Are there any deployment considerations?
no
Does this work require review from our design team?
no