Fix unquoting queries with non escape characters #8562
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
strconv.Unquote
is intended for use in cases where you are processing go source code, so there are some rough edges when trying to unquote a string passed in from the frontend. Mainly, it cannot parse\d
or \w` and other regex expressions since they are not valid go escape keys.Update the method to trim the quotes and replace any internal quotes with the non escaped version - like we previously did for single quotes
'
https://www.loom.com/share/e30f51d823d541e0a78d194139b95a85?sid=c5f92a46-e7df-4709-a30a-12b648bd0649
How did you test this change?
matches
operator/n
) or word (/w
) to the search within the quotes"
Are there any deployment considerations?
N/A
Does this work require review from our design team?
N/A