Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop polling for more resources after 15 mins #8628

Merged
merged 5 commits into from
May 21, 2024
Merged

Conversation

mayberryzane
Copy link
Contributor

Summary

  • stop polling after 15 mins
  • set a pollingExpired variable, show "load more results" after this time has passed

How did you test this change?

  • clicktested locally w/ shorter polling expiry time

Are there any deployment considerations?

  • no

Does this work require review from our design team?

  • no

Copy link

changeset-bot bot commented May 20, 2024

⚠️ No Changeset found

Latest commit: 57ae8f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@mayberryzane mayberryzane changed the title stop polling after 15 mins stop polling for more resources after 15 mins May 20, 2024
@mayberryzane mayberryzane requested review from a team and SpennyNDaJets and removed request for a team May 20, 2024 17:15
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Summary

  • Introduces a mechanism to stop polling after 15 minutes, setting a pollingExpired variable to show a 'load more results' option across various components.
  • Updates FeedResults.tsx, SearchContext.tsx, ErrorsV2.tsx, SearchPanel.tsx, useGetErrors.ts, LogsPage.tsx, LogsTable.tsx, useGetLogs.ts, PlayerPage.tsx, SessionsFeedV3.tsx, useGetSessions.ts, TracesList.tsx, TracesPage.tsx, useGetTraces.ts, and search.ts to handle the new polling behavior.
  • Downgrades protobufjs and protobufjs-cli versions in yarn.lock.

Notes

  • Ensure the pollingExpired state is managed correctly to avoid unintended behavior.
  • Potential performance improvement by preventing indefinite polling.

yarn.lock Outdated Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
frontend/src/util/search.ts Outdated Show resolved Hide resolved
@mayberryzane mayberryzane merged commit 12530cf into main May 21, 2024
21 checks passed
@mayberryzane mayberryzane deleted the zane/polling_stop branch May 21, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants