-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stop polling for more resources after 15 mins #8628
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Summary
- Introduces a mechanism to stop polling after 15 minutes, setting a
pollingExpired
variable to show a 'load more results' option across various components. - Updates
FeedResults.tsx
,SearchContext.tsx
,ErrorsV2.tsx
,SearchPanel.tsx
,useGetErrors.ts
,LogsPage.tsx
,LogsTable.tsx
,useGetLogs.ts
,PlayerPage.tsx
,SessionsFeedV3.tsx
,useGetSessions.ts
,TracesList.tsx
,TracesPage.tsx
,useGetTraces.ts
, andsearch.ts
to handle the new polling behavior. - Downgrades
protobufjs
andprotobufjs-cli
versions inyarn.lock
.
Notes
- Ensure the
pollingExpired
state is managed correctly to avoid unintended behavior. - Potential performance improvement by preventing indefinite polling.
Summary
pollingExpired
variable, show "load more results" after this time has passedHow did you test this change?
Are there any deployment considerations?
Does this work require review from our design team?