fix(rust) escaped double quotes in string (#3904)

highlightjs · Nov 7, 2023 · 3270ef9 · 3270ef9
1 parent fd28298
commit 3270ef9
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 1 deletion.
diff --git a/CHANGES.md b/CHANGES.md
@@ -4,6 +4,7 @@ Core Grammars:
 
 - fix(css) fix overly greedy pseudo class matching [Bradley Mackey][]
 - enh(arcade) updated to ArcGIS Arcade version 1.24 [Kristian Ekenes][]
+- fix(rust) fix escaped double quotes in string  [Mohamed Ali][]
 - fix(yaml) fix for yaml with keys having brackets highlighted incorrectly [Aneesh Kulkarni][]
 - fix(bash) fix # within token being detected as the start of a comment [Felix Uhl][]
 
@@ -15,6 +16,7 @@ Developer Tool:
 
 - enh(tools): order CSS options picklist [David Schach][]
 
+[Mohamed Ali]: https://github.com/MohamedAli00949
 [Bradley Mackey]: https://github.com/bradleymackey
 [Kristian Ekenes]: https://github.com/ekenes
 [Aneesh Kulkarni]: https://github.com/aneesh98

diff --git a/src/languages/rust.js b/src/languages/rust.js
@@ -231,7 +231,10 @@ export default function(hljs) {
           {
             className: 'string',
             begin: /"/,
-            end: /"/
+            end: /"/,
+            contains: [
+              hljs.BACKSLASH_ESCAPE
+            ]
           }
         ]
       },

diff --git a/test/markup/rust/strings.expect.txt b/test/markup/rust/strings.expect.txt
@@ -16,3 +16,5 @@
 <span class="hljs-string">br&quot; &quot;</span>;
 <span class="hljs-string">br#&quot;hello&quot;#</span>;
 <span class="hljs-string">br##&quot;foo&quot;##</span>;
+
+<span class="hljs-meta">#[error(<span class="hljs-string">&quot;\&quot; appears in a string&quot;</span>)]</span>
diff --git a/test/markup/rust/strings.txt b/test/markup/rust/strings.txt
@@ -16,3 +16,5 @@ r##" "###
 br" ";
 br#"hello"#;
 br##"foo"##;
+
+#[error("\" appears in a string")]