issue in highlighting fortran code: kind of intrinsic data type

[kookma]

In modern fortran you can set the kind of intrinsic data type. It means you can define additional intrinsic data type. When you do so, for literal constants you have to use the kind name attached to literal consonant using under score.

Example

PROGRAM test_initial
INTEGER, PARAMETER :: DBL = SELECTED_REAL_KIND(p=13)
REAL(KIND=DBL) :: a1 = 6.666666666666666
REAL(KIND=DBL) :: a2 = 6.666666666666666_DBL
WRITE (*,*) a1, a2
END PROGRAM test_initial

Highlight.js issue

When using highlight.js to highlight a Fortran code contains such named constant, highlight.js fails to do the job! It highlights the remaining code (from the position of named constant) in a wrong way!

Note

• The above code in this post is highlighted by github, it works correctly! See the name constant is in blue color.
• other intrinsic data can have other kind. But in all cases in named constants, the kind is specified by an underscore to the constant (e.g 12_ps)

[kookma]

Solution

This is the solution to the above question.
The "number" class in fortran.js file shall be corrected as bellow:

{
        className: 'number',
        begin: '(?=\\b|\\+|\\-|\\.)[+-]?(?:\\.|\\d+\\.?)\\d*([de][+-]?\\d+)?(_[a-z\\d]+)?\\b',
        relevance: 0
      }

[kookma]

Is there any chance to be merged in the new revision of main release?

[egor-rogov]

@kookma Could you make a PR out of this (plus some tests)?

[kookma]

Sure, but I don't know how to make a PR? Should I fork this repo?

[egor-rogov]

Yes, first fork the repo and commit changes to it. Then in your repo on "Pull requests" tab find "New pull request" button.

[kookma]

@egor-rogov
Sure, I do it.

[kookma]

@egor-rogov
Please have a look at: #1934

[joshgoebel]

See also #1566

[kookma]

@yyyc514
Thank you for following up this issue!
Highlight.js is used in many webpages have Fortran stuffs so it worth to correct the issue!
I saw #1566 and will try that!
My simple solution above works for me but I am not a regex expert to see if the solution is correct or not!

[kookma]

@yyyc514
I check the new fix on https://jsfiddle.net/ajoshguy/nagkqytv/11/
by trying the below code:

<pre>
<code class="fortran">
program main
! This is a test
real :: x, y
x=1.23_wp
y=0._wer
z=1.25e9
end program main
</code>
</pre>

And it seems you solution from #1566 works!

So, I think you can to close this issue.

[joshgoebel]

Well, our desire is the highlight the WHOLE number, including the "kind", that's why this is still open. What should be fixed now if us "losing" the first digit, which was not good at all.

[kookma]

@yyyc514

What I checked at https://jsfiddle.net/ajoshguy/nagkqytv/11/ is

program main
! This is a test
real :: x, y
x=1.23_wp
y=0._wer
z=1.25e9
end program main

and it shows the whole number including the first number and the kind highlighted!
I mean number like 12.34_wp

I am afraid I don't understand what you explained.

[joshgoebel]

Not sure what you are seeing, but this is not correct yet. And it can't be since the regex hasn't been updated. Its' possible you're seeing some other language highlighting the code instead.

[kookma]

I see it as below, so it works at https://jsfiddle.net/ajoshguy/nagkqytv/11/

[joshgoebel]

Not Fortran. :-) Did you tell it to load fortran in the init config?

[kookma]

Where is that? I just used <code class="fortran">
I assume it loads all language brushes!

[joshgoebel]

No it loads only the common set. It's at the top of the file. It's meant to be as close as possible to an actual usage, so it would be a poor testing environment if it loaded EVERYTHING.

[kookma]

@yyyc514 okay, I changed the first like to var language = "fortran"; and now I see what you posted!

In my revised version as I explained above I use

{
        className: 'number',
        begin: '(?=\\b|\\+|\\-|\\.)[+-]?(?:\\.|\\d+\\.?)\\d*([de][+-]?\\d+)?(_[a-z\\d]+)?\\b',
        relevance: 0
      }

and it works fine. Have a look at

https://kookma.github.io/TW-Scripts/#Syntax%20Highlighting:%5B%5BSyntax%20Highlighting%5D%5D%20%24%3A%2Fplugins%2Ftiddlywiki%2Fhighlight%20%24%3A%2Fplugins%2Ftiddlywiki%2Fhighlight%2Fhighlight.js

Here I use highlight.js as plugin! Scroll down to see the modified highlight.js

[kookma]

You can edit online the content and check Fortran code of your own!
Edit change and then push the save button!

[joshgoebel]

Yeah, we've been debating on the correct/best match rule. That might wait till .12 though, depends how much time I have between now and release.

My priority was first fixing the data loss.

[kookma]

Okay! Thank you for all your efforts.

[kookma]

@yyyc514
I have checked 9.18.1 the issue #1723 (comment)

still there!

[joshgoebel]

The full fix should be in 10.0. Pretty sure we closed this one down. Please test on the 10.0 beta.

[kookma]

many thanks Josh!