Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Scala highlighting #930

Closed
prurph opened this issue Sep 12, 2015 · 8 comments
Closed

Incorrect Scala highlighting #930

prurph opened this issue Sep 12, 2015 · 8 comments
Labels
Milestone

Comments

@prurph
Copy link

prurph commented Sep 12, 2015

This affects most themes and seems to be because there is no hljs-params scope or the like defined. Here is an example from the demo on the main site:

highlight js demo 2015-09-12 09-06-40

@Sannis Sannis added the bug label Sep 12, 2015
@Sannis Sannis added this to the 8.9 milestone Sep 12, 2015
@Sannis Sannis self-assigned this Sep 12, 2015
@Sannis
Copy link
Collaborator

Sannis commented Sep 12, 2015

@prurph I can reproduce something like this only when using :common set of languages, in this case this fragment recognised as Ruby. But we do not have Scala example on site index page. How are you get this?

screen shot 2015-09-12 at 17 40 18

@Sannis
Copy link
Collaborator

Sannis commented Sep 12, 2015

Site live demo also looks good at this moment:
screen shot 2015-09-12 at 17 44 54

@Sannis Sannis closed this as completed Sep 12, 2015
@prurph
Copy link
Author

prurph commented Sep 12, 2015

I was talking about the live demo you just linked. In that screenshot the colors are actually showing the same issue--note how the : after things and the first paren after spindle are blue.

@Sannis Sannis reopened this Sep 12, 2015
@Sannis
Copy link
Collaborator

Sannis commented Sep 12, 2015

My bad(

@isagalaev
Copy link
Member

Yeah, the problem is definitely there but it seems to be fixed in the new-styles branch which is an overhaul of class names and styles across all the languages: #348. And it's actually nearing completion!

@Sannis
Copy link
Collaborator

Sannis commented Sep 12, 2015

Also current language definition looks strange - in this fragment type T; is class, val things: Seq[T] is function. Unfortunately I'm not familiar with Scala to properly fix this.

@Sannis Sannis removed their assignment Sep 12, 2015
isagalaev added a commit that referenced this issue Sep 12, 2015
This one fixes a side issue in #930. The overall issues is taken care
of by the class names refactoring in #348.
@isagalaev
Copy link
Member

I demoted val from starting a function, so things in the example is no longer a title. I will also close the issue as the params mis-highlighting is fixed in the new-styles branch.

Thanks for reporting this!

@prurph
Copy link
Author

prurph commented Sep 12, 2015

Awesome! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants