Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong syntax highllighting with JS (es6) template string #958

Closed
MoOx opened this issue Oct 19, 2015 · 8 comments
Closed

Wrong syntax highllighting with JS (es6) template string #958

MoOx opened this issue Oct 19, 2015 · 8 comments
Assignees
Labels
Milestone

Comments

@MoOx
Copy link

MoOx commented Oct 19, 2015

Here is a snippet that create a bug (correctly parsed as lang-js)

import path from "path"

module.exports = {
  entry: {
    index: [ `${ src }/index.js` ],
  },
}

screen shot 2015-10-19 at 22 32 31

screen shot 2015-10-19 at 22 34 05

Note that this snippet is totally ok

module.exports = {
  entry: {
    index: [ `${ src }/index.js` ],
  },
}

screen shot 2015-10-19 at 22 33 23

screen shot 2015-10-19 at 22 35 04

@Sannis Sannis added the bug label Oct 19, 2015
@Sannis
Copy link
Collaborator

Sannis commented Oct 19, 2015

@MoOx it is because fist line is detected as import and did not found ; that may be skipped in JS.

@Sannis Sannis added this to the 8.9 milestone Oct 19, 2015
@Sannis Sannis self-assigned this Oct 19, 2015
@Sannis Sannis closed this as completed in f63d81c Oct 19, 2015
Sannis added a commit to Sannis/highlight.js that referenced this issue Oct 19, 2015
Sannis added a commit to Sannis/highlight.js that referenced this issue Oct 19, 2015
…lon, fixes highlightjs#958"

This reverts commit f63d81c.

# Conflicts:
#	CHANGES.md
@Sannis Sannis reopened this Oct 19, 2015
@Sannis Sannis modified the milestones: 8.10, 8.9 Oct 19, 2015
Sannis added a commit to Sannis/highlight.js that referenced this issue Oct 20, 2015
@Sannis Sannis closed this as completed in 4decafa Oct 21, 2015
@isagalaev isagalaev modified the milestones: 8.10, 9.0 Oct 27, 2015
@MoOx
Copy link
Author

MoOx commented Oct 29, 2015

Rough ETA for 9.0 ?

@isagalaev
Copy link
Member

@MoOx the change from 8.10 to 9.0 is simply a rename, as the next release is going to break backwards compatibility with existing class names (see #348). The date is remains the same: December, 1.

@MoOx
Copy link
Author

MoOx commented Oct 29, 2015

Oh sorry I didn't check the milestone date. Why in a month (just curious)?

@isagalaev
Copy link
Member

We're now doing regular releases on a 6-week cadence. The number seems to be a sort of an industry practice and may change if we see it doesn't work for us. So far it does :-)

@MoOx
Copy link
Author

MoOx commented Oct 29, 2015

Ok good to know. Thanks !
I guess I can use the master branch directly via npm :)

@isagalaev
Copy link
Member

The master branch is not on npm, you'll have to get the source and build it, here's our building docs.

@MoOx
Copy link
Author

MoOx commented Oct 29, 2015

npm can grab a git repo, so I can reference the repo and use your build command as a postinstall script ;)
Thanks for the link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants