Add missing "object" highlighting to Pony definition #1932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original Pony highlighting definition that Joe did is missing a Pony keyword for highlighting like a class. After consulting with other Pony committers and comparing results, we feel this small change is a big improvement when highlighting Pony's object literals.
|
@SeanTAllen Thanks, merged! |
|
Thanks @egor-rogov. I'm not familiar with Markup tests. Is there some documentation you can point me at? Any plans on another highlight release soon that this change would go out with? |
|
@SeanTAllen You can read this page (Testing Markup section): https://highlightjs.readthedocs.io/en/latest/building-testing.html |
|
As for the next release, we can ask @marcoscaceres about the plans. |
|
I'll try to push one out now. |
Merged
|
Ok, 9.14.1 was released. |
|
Thanks @marcoscaceres! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original Pony highlighting definition that Joe did is missing a Pony
keyword for highlighting like a class. After consulting with other Pony
committers and comparing results, we feel this small change is a big
improvement when highlighting Pony's object literals.