Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(sql) Backslash should not escape in string #2301

Merged
merged 2 commits into from
Dec 7, 2019

Conversation

schallm
Copy link
Contributor

@schallm schallm commented Nov 24, 2019

Remove backslash_escape with in strings in standard SQL

Closes #1748.

@joshgoebel
Copy link
Member

Please add all 3 string types and examples of escapes to the expects test. And we need a changeling entry also. :)

Thanks!

@joshgoebel joshgoebel self-requested a review November 25, 2019 13:45
@joshgoebel joshgoebel changed the title Backslash should not escape in string in sql (sql) Backslash should not escape in string Nov 25, 2019
@egor-rogov
Copy link
Collaborator

Hmm, strings in backticks are out of standard altogether. Anyone knows what database uses them?

@joshgoebel
Copy link
Member

@joshgoebel
Copy link
Member

@egor-rogov Thoughts? If there is still a separate issue here might we keep this focused on the original issue and perhaps create a new issue for the backtick issue?

I think this solves the original issue, yes?

@joshgoebel joshgoebel added this to the 9.17 milestone Dec 6, 2019
@joshgoebel joshgoebel added this to In Progress in Highlight.js Dec 7, 2019
@joshgoebel joshgoebel moved this from In Progress to 9.17 in Highlight.js Dec 7, 2019
@egor-rogov
Copy link
Collaborator

@egor-rogov Thoughts? If there is still a separate issue here might we keep this focused on the original issue and perhaps create a new issue for the backtick issue? I think this solves the original issue, yes?

Absolutely.
As for backticks, looks like we cannot remove it until MySQL gets its own grammar, so let them be.

@joshgoebel joshgoebel merged commit 62fdd69 into highlightjs:master Dec 7, 2019
Highlight.js automation moved this from 9.17 to Done Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Highlight.js
  
Done
Development

Successfully merging this pull request may close these issues.

(sql) single backslash inside a string literal seems to not be valid
3 participants