Version 10 misc chores and small breaking changes #2325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshgoebel
added
enhancement
joshgoebel
force-pushed
the
wip_version_10
branch
from
8e0f059
to
188a198
Compare
joshgoebel
force-pushed
the
wip_version_10
branch
6 times, most recently
from
3b0a63f
to
d029109
Compare
joshgoebel
changed the title
egor-rogov
reviewed
Jan 7, 2020
|
Anything else? |
|
I think I plan to merge this first, so now the other big PR is pending based on this one being approved. :-) |
egor-rogov
approved these changes
Jan 23, 2020
You don't need to remind me. :-) I'll make sure it all comes together properly. :-) Then once this better foundation is in place I'll try to go back to some smaller changes you'll find easier to review. :-) |
...in favor of only the newer `DOMContentLoaded`
- chore(parser): effectively rename `cpp.js` to `c-like.js` [Josh Goebel][] - chore(parser): create new `c.js` (C), depends on `c-like` now [Josh Goebel][] - chore(parser): create new `cpp.js` (C), depends on `c-like` now [Josh Goebel][] - This will allow us to clean up C/C++ in the future without another breaking change by getting this require change out of the way early. (#2146)
joshgoebel
force-pushed
the
wip_version_10
branch
from
d029109
to
7bd464d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should go a long ways towards closing #2273, but not completely.