enh(Python) Some Python language improvements #2715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Keywords now correspond exactly to the list in section 2.3.1 of the [Python 3.8 reference][1]. Reserved identifiers are not considered. * Built-in literal constants now correspond exactly to those listed in the reference [2]. * Built-in functions correspond to those listed in the reference [3]. * Built-ins aren’t highlighted directly after a dot; this corresponds to how the IPython REPL highlights e.g. `x.len()` and (incorrectly) `x. len()`. [1]: https://docs.python.org/3/reference/lexical_analysis.html#keywords [2]: https://docs.python.org/3/library/constants.html [3]: https://docs.python.org/3/library/functions.html
* Remove invalid 'ur' prefix combination * Add 'br' prefix combination * Make string prefixes case insensitive
klmr
changed the title
joshgoebel
requested changes
Sep 30, 2020
|
@klmr Thanks for the effort here! |
|
Also, please add a few entries to |
|
I’m happy to take a look at #2633 but I think that should be a separate PR. |
|
Of course. |
joshgoebel
reviewed
Oct 3, 2020
joshgoebel
reviewed
Oct 3, 2020
joshgoebel
approved these changes
Oct 3, 2020
joshgoebel
approved these changes
Oct 3, 2020
|
@klmr Thanks fo much for all the effort on this! |
|
Well, grrr... I didn't mean to truncate all those great notes from the commit, grrrr... |
|
Ha, no worries. If somebody’s interested they can refer back to the linked PR for the notes. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I’m happy to pull these out into separate PRs if that’s more appropriate!)
Details:
Fix keywords and builtins
Built-ins aren’t highlighted directly after a dot; this corresponds to how the IPython REPL highlights e.g.x.len()and (incorrectly)x. len().Fix string prefixes