(VB.Net) Date literals, Directives, Comments, test cases

[Hirse]

Resolves #2775, resolves #2875, resolves #2851

Changes

• Adds support for Date data types, see (VB.Net) Doesn't highlight date literals e.g. #7/26/1970# #2775
• Adds support for REM-comments and fixes ''' doctags, see (VB.Net) Incorrect highlighting of Rem Comments #2851 and (vb.net) Comments need to be reworked - < in comment breaks highlighting #2875
• Switches from C number mode to custom number mode to support VB.net specifics
  • Hex (&H), Oct (&O), and binary (&B) prefixes
  • Separating digits with underscores: 90_946
  • Type suffixes: 123UI (unsigned integer)
• Improves Directives detection and adds support for Enable, Disable, and Then keywords
• Adds more markup test for vbnet
• Fixes imports statements in detect file

Checklist

• Added markup tests
• Updated the changelog at CHANGES.md
• Added myself to AUTHORS.txt, under Contributors Already there 😉

[Hirse]

The Microsoft Docs site seems to use a fork of HLJS (v9) which adds support for date literals ...

... but breaks Directives (by looking for the ending #).

Both of which should now work as expected.

[joshgoebel]

https://docs.microsoft.com/en-us/dotnet/visual-basic/language-reference/data-types/date-data-type

You must enclose a Date literal within number signs (# #). You must specify the date value in the format M/d/yyyy, for example #5/31/1993#, or yyyy-MM-dd, for example #1993-5-31#. You can use slashes when specifying the year first. This requirement is independent of your locale and your computer's date and time format settings.

So I think that means we can have two variants for each of the possible date literals.

[joshgoebel]

This could land in 10.4 if you have time to finish it up soon.

[Hirse]

I'm working on it. 😄

[joshgoebel]

Awesome this is looking pretty good.

[joshgoebel]

I think those 3 things are it. Looking pretty awesome. :-)

[joshgoebel]

Are the float tests I added all still valid? We had cases we weren't covering.

I simplified the date/time stuff a little with the helpers we have.

[Hirse]

Yes, the tests look good.

[joshgoebel]

@Hirse Thanks for all the hard work and closing 3 issues!!!