enh(cpp) simpler struct matching #3078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Right now I'm using
|
joshgoebel
force-pushed
the
cpp_struct_class_etc
branch
2 times, most recently
from
f239ffe
to
8cf00fe
Compare
joshgoebel
force-pushed
the
cpp_struct_class_etc
branch
2 times, most recently
from
79025b1
to
80d5b9b
Compare
|
This is currently rebased on the multi-class stuff (so I could finish it), but in review that can be ignored. |
joshgoebel
force-pushed
the
cpp_struct_class_etc
branch
from
80d5b9b
to
55dd7a6
Compare
joshgoebel
force-pushed
the
cpp_struct_class_etc
branch
3 times, most recently
from
33016b3
to
0394a55
Compare
joshgoebel
commented
Apr 12, 2021
There was a problem hiding this comment.
Self-approving. @allejo If you have time to look at this later and see anything terrible please let me know.
joshgoebel
force-pushed
the
cpp_struct_class_etc
branch
2 times, most recently
from
1729d4f
to
61777e0
Compare
NullVoxPopuli
approved these changes
Apr 13, 2021
This is built into the core compiler now.
joshgoebel
force-pushed
the
cpp_struct_class_etc
branch
from
61777e0
to
73e60ee
Compare
joshgoebel
force-pushed
the
cpp_struct_class_etc
branch
from
73e60ee
to
e2d8ab5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2736. Resolves #2520. Resolves #3112.
Changes
beforeMatchcompiler extensiontitle.classsub-scope support. Related More nuance for match classes (class title? function title? etc.) #2521.Seems to do about as well as GitHub now.
Checklist
beforeMatchCHANGES.md