chore(themes) remove builtin-name CSS class
#3119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Removed the
builtin-namereplacing it withbuilt_inin the few (4-5)grammars it was used. Also only 4 themes made any distinction between
built_in and builtin-name, the rest choosing to style these exactly the
same - so it's never been clear what the difference is or there is none.
If more nuance is needed here it should be addressed via #2500 and #2521.
In only one grammar was both
built_inandbuiltin-nameused side byside so other than that (in combo with very particular themes) this
should be a quiet change.
Checklist
CHANGES.md