Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Papyrus #3125

Merged
merged 5 commits into from
Apr 12, 2021
Merged

Added Papyrus #3125

merged 5 commits into from
Apr 12, 2021

Conversation

Pickysaurus
Copy link
Contributor

@Pickysaurus Pickysaurus commented Apr 11, 2021

Changes

Added link to my parser for Papyrus, the coding language used by Bethesda games.

Checklist

  • Added markup tests, or they don't apply here because...
  • Updated the changelog at CHANGES.md (Does this apply here?)

Added link to my parser for Papyrus, the coding language used by Bethesda games.
@joshgoebel
Copy link
Member

Please add changelog entry as well.

Also typically the naming convention is highlightjs-papyrus not highlight.js-papyrus.

@joshgoebel
Copy link
Member

I left a few notes if you want to take them into consideration.

Copy link
Member

@joshgoebel joshgoebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need that changelog entry. :)

@Pickysaurus
Copy link
Contributor Author

Sorry, I did this through the GitHub site, so it was easier to do it across several commits. If you left any more comments I'm unsure where they are.

Thanks

@joshgoebel
Copy link
Member

Could you add a usage example to your README like the other grammars have?

Example:
https://github.com/highlightjs/highlightjs-robots-txt

@joshgoebel
Copy link
Member

If you left any more comments I'm unsure where they are.

I left them on the original commits.

@Pickysaurus
Copy link
Contributor Author

Thanks, I'm having a few issues getting NPM to work (I've never used it before) but other than that I've made the changes.

I'll see if I can improve it based on your suggestions when I have time. Currently, it spits out the code in a visually relevant way, so I'm happy with it.

@joshgoebel joshgoebel merged commit ed4e04e into highlightjs:main Apr 12, 2021
@joshgoebel
Copy link
Member

@Pickysaurus Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants