Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(themes) Add all Base16 themes #3139

Merged
merged 7 commits into from
May 2, 2021

Conversation

joshgoebel
Copy link
Member

@joshgoebel joshgoebel commented Apr 14, 2021

Changes

Keep our base16 themes separate from the rest and add builds of other Base16 themes.

Resolves #3132.

Checklist

  • Added markup tests, or they don't apply here because...
  • Updated the changelog at CHANGES.md

@joshgoebel joshgoebel added this to the 11.0 alpha 1 milestone Apr 15, 2021
@joshgoebel joshgoebel changed the title WIP: move base16 themes into subdir enh(themes) Add all Base16 themes Apr 16, 2021
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I much prefer this separation :D

@joshgoebel joshgoebel merged commit 5960edc into highlightjs:main May 2, 2021
@Hirse
Copy link
Contributor

Hirse commented May 16, 2021

What happened to the sorting of the themes in developer.html?
Is this intentional?
Unsorted list of themes

@joshgoebel
Copy link
Member Author

Nope, accident. Honestly though this shouldn't be manually updated at all. We should probably make the whole thing a template and build it (with auto-populated CSS list) when we build demo. This would also allow us to point people to the developer tool online in the future (for testing), which would be a big win.

stevenjoezhang added a commit to next-theme/hexo-theme-next that referenced this pull request Feb 6, 2022
ljcbaby pushed a commit to ljcbaby/hexo-theme-next that referenced this pull request Feb 7, 2022
ljcbaby pushed a commit to next-theme/hexo-theme-next that referenced this pull request Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: Build Base16 themes auto-magically
4 participants