(chore) fix CSS in the dev tool to be cross-browser once again #3292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Snap? :) Does it look equally snazzy or did we revert to the older style? |
|
Just added a screenshot, I think it looks just as snazzy 😄 It preserves the same behavior as far as I can tell. |
|
Could we get maybe 1-3px of padding between the double dashed lines so it's easier to see the bounding rects? (ie bottom padding on the spans I think) I'll merge either way but I think that would be small improvement. |
joshgoebel
approved these changes
Aug 1, 2021
joshgoebel
changed the title
|
I added a padding of 5px. 3px seemed like too little for me. |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3133
Fixes #3290
Changes
Replace CSS that only worked on Gecko browsers with more generic CSS
Checklist
CHANGES.md