Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css-like) Now always detect block comments #3301

Merged
merged 5 commits into from
Aug 18, 2021

Conversation

joshgoebel
Copy link
Member

@joshgoebel joshgoebel commented Aug 5, 2021

  • (enh) CSS consistency for function dispatch
  • enh(css-like) detect block comments better

Attemps to resolve #3299.

Changes

  • Detect block comment even in the value portion
  • Add function dispatch highlighting to all CSS-like grammars.

Checklist

  • Added markup tests, or they don't apply here because...
  • Updated the changelog at CHANGES.md

@joshgoebel joshgoebel requested a review from allejo August 13, 2021 23:29
Copy link
Member

@allejo allejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR doesn't directly touch keywords in keyframes but from/to aren't highlighted in Scss + Stylus; though this could probably be another issue. Otherwise, LGTM 👍

image
image
image
image

@joshgoebel
Copy link
Member Author

This PR doesn't directly touch keywords in keyframes but from/to aren't highlighted in Scss + Stylus;

Yeah, I was just trying to make some progress here, not fix everything. :) Problem for another day. :) Thanks for such detailed review.

@joshgoebel
Copy link
Member Author

joshgoebel commented Aug 18, 2021

I'm not 100% persuaded from and to should be highlighted either, since they are contextual. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(CSS) Inline comments are not highlighted correctly (regression between 10.5.0 and 10.6.0)
2 participants