Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(js/ts) regex inside SUBST is no longer highlighted #3320

Merged
merged 1 commit into from
Sep 3, 2021
Merged

fix(js/ts) regex inside SUBST is no longer highlighted #3320

merged 1 commit into from
Sep 3, 2021

Conversation

joshgoebel
Copy link
Member

@joshgoebel joshgoebel commented Sep 1, 2021 •
edited

Resolves #3288.

Checklist

  • Added markup tests, or they don't apply here because we don't typically test negatives
  • Updated the changelog at CHANGES.md

allejo
allejo approved these changes Sep 3, 2021
View reviewed changes
Copy link
Member

@allejo allejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended 👍 I hope it's no big loss for having regex support removed from {}

@joshgoebel joshgoebel merged commit 2ad69e8 into highlightjs:main Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allejo allejo allejo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(Javascript) Slashes in template literal break parsing
2 participants
@joshgoebel @allejo