Changes to theme background color for Gradient Light and Gradient Dark themes #3408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshgoebel
reviewed
Nov 29, 2021
joshgoebel
reviewed
Nov 29, 2021
joshgoebel
reviewed
Nov 29, 2021
src/styles/gradient-dark.css
Outdated
Comment on lines
9
to
11
| display: block; | ||
| overflow-x: auto; | ||
| padding: 0.5em; |
There was a problem hiding this comment.
Do not add these, these are added during the build process.
|
Any further context for the "why" of this change? |
Wanted to enhance the background of the original themes: additionally made the color of .hljs-string in the light theme a little darker so it's visible in contrast with the background-just some aesthetic changes I thought would look better. |
joshgoebel
approved these changes
Nov 30, 2021
|
@samiaab1990 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the background color for Gradient Light and Gradient Dark themes
Changes
Changed background color of Gradient Light to:
background-color: #f9ccff; background-image: linear-gradient(295deg, #f9ccff 0%, #e6bbf9 11%, #9ec6f9 32%, #55e6ee 60%, #91f5d1 74%, #f9ffbf 98%);frombackground: rgb(255,253,141); background: linear-gradient(142deg, rgba(255,253,141,1) 0%, rgba(252,183,255,1) 35%, rgba(144,236,255,1) 100%);Changed background color of Gradient Dark to:
background-color: #4e037d; background-image: linear-gradient(162deg, #4e037d 8%, #40006a 22%, #270075 60%, #032e79 92%); ;frombackground-color: #280760; background-image: linear-gradient(225deg, #280760 47%, #03135e 92%);Checklist
CHANGES.md- added changes under Themes: