Add GraphQL

[jf990]

Add grammar GraphQL

Changes

languages/graphql.js, detect and markup tests

Checklist

• Added markup tests
• Updated the changelog at CHANGES.md

[joshgoebel]

Lots of tiny things, but overall looks good - shouldn't be super hard to finish up.

[joshgoebel]

I plan to push a release in next few days just heads up, if this is ready it'll land in that.

[jf990]

@joshgoebel suggestions applied and tested, looks good to me. thanks for your review.

[joshgoebel]

Ping.

[joshgoebel]

Can't tell what you changed, I'm not seeing changes on the comments I posted...?

[jf990]

@joshgoebel not sure how I missed your comments but I did, looking at it now.

[joshgoebel]

Almost there. :-) Thanks for all the effort.

[joshgoebel]

Long term (if we consider this for adding to default) we might need to add some combo rules such as:

mutation [IDENT_RE] {... and of course the mutation name would also be a title.class, etc... So then that would only match mutation Book { but not mutation { from some other language... and then we could perhaps bump the relevance for those keywords (in context) a little higher... but I think this is a good start for now.

[joshgoebel]

Cool, I'll let this simmer another day or two then circle back for a final review. I find that often catches things I miss, but I I can probably fix up anything else I find. Thanks for all the help!

[joshgoebel]

@jf990 Thanks for all the work on this!

[joshgoebel]

Size Change: +1.15 kB (0%)
Total Size: 715 kB

Filename	Size	Change
./build/es/languages/stata.min.js	6.65 kB	+10 B (0%)
./build/languages/pf.min.js	849 B	+6 B (+1%)
./build/languages/stata.min.js	6.66 kB	+13 B (0%)
./build/es/languages/graphql.min.js	543 B	+543 B (new file)	🆕
./build/languages/graphql.min.js	550 B	+550 B (new file)	🆕

[jf990]

@joshgoebel thanks for your help, definitely much better thanks to your review feedback.