Respect --no-minify when building CDN assets #3913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build Size ReportChanges to minified artifacts in 3 files changedTotal change +6 B View Changes
|
joshgoebel
force-pushed
the
allejo/respect-non-min-cdn
branch
from
b762e81
to
4bb5eb1
Compare
joshgoebel
approved these changes
Nov 2, 2023
Build Size ReportChanges to minified artifacts in 3 files changedTotal change +6 B View Changes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building the grammars for CDN, they will always be minified in the build directory, regardless of the
--no-minifyflag given totools/build.js.Changes
I know CDN assets will never be published in a non-minified format. However, if these grammars are built in a non-minified way, they can be used to address highlightjs/highlightjs.org#5. Since the
/downloadbundle uses a concatenated version of minified grammars, the non-minified distribution should use the same grammars.