Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dart language support #426

Closed
wants to merge 1 commit into from
Closed

Dart language support #426

wants to merge 1 commit into from

Conversation

dikmax
Copy link
Contributor

@dikmax dikmax commented Feb 22, 2014

Added Dart support (https://www.dartlang.org/).
New CSS class .hljs-dartdoc added to every style in same place as .hljs-phpdoc.

@Sannis
Copy link
Collaborator

Sannis commented Feb 22, 2014

New CSS class .hljs-dartdoc added to every style in same place as .hljs-phpdoc.

It looks like we should reuse annotation class for such things in future. And the dartdoc should be just comment.

@dikmax
Copy link
Contributor Author

dikmax commented Feb 22, 2014

Yes, but we should choose another name. annotation is used for actually annotations:

@Deprecated
class SomeClass {}

@isagalaev
Copy link
Member

I'm happy with .hljs-dartdoc for now because it's consistent with javadoc, phpdoc and some others. This is not an ideal situation and we're gonna deal with it as a part of the overall unification/simplification of styling classes (see also #348) which is bound to be backwards-incompatible and thus won't happen very soon.

@myitcv
Copy link

myitcv commented Jul 23, 2014

Any updates on this? Would be a great addition to highlight.js and by implication Markdown here

@myitcv
Copy link

myitcv commented Jul 23, 2014

I've rebased this against master in #516

@dikmax
Copy link
Contributor Author

dikmax commented Jul 23, 2014

Rebase against new updated master

@dikmax
Copy link
Contributor Author

dikmax commented Jul 23, 2014

Any thoughts about this pull request? What prevents it from being merged into master?

@isagalaev
Copy link
Member

@dikmax we'll get around to it when time allows. We'd all want things to happen faster, but there's only so much we can do, sorry!

@isagalaev
Copy link
Member

Oh, and thanks a lot for rebasing the branch!

@myitcv
Copy link

myitcv commented Aug 4, 2014

Aside from dealing with the merge conflicts at the time of writing this comment, is there anything else you the owners/contributors to highlight.js need before this can be merged?

@isagalaev
Copy link
Member

I'm working on it in my local branch now. It needed some work on cross-language relevance and I hope to have it merged this week (this week is my "highlight.js" week :-) )

@isagalaev isagalaev self-assigned this Aug 4, 2014
@myitcv
Copy link

myitcv commented Aug 4, 2014

@isagalaev - thanks very much in advance!

@isagalaev
Copy link
Member

It looks like I merged the other PR, #516 after all. But I suppose they are functionally equivalent.

One thing of note is that dartdoc is styled in bold font in default.css which to my eye looks wrong. I'll be happy to merge another PR removing dartdoc-specific rules but I'll let you (collectively) be the judge on that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants