Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax Highlighting for AspectJ #598

Closed
wants to merge 1 commit into from
Closed

Syntax Highlighting for AspectJ #598

wants to merge 1 commit into from

Conversation

ozlerhakan
Copy link
Contributor

I tackled the AspectJ language in order to make its keywords more readeable for all user.
I hope this pull will be accepted by you.

@ozlerhakan
Copy link
Contributor Author

could you please explain why this should be detected as java. AspectJ has a separate source code file ending with .aj and it supports nested interface, class and aspect declarations.

@isagalaev
Copy link
Member

The wording of the test is not very clear, sorry. The problem is that with the addition of your AspectJ definition the Java code is now being mis-detected as AspectJ. A way to fix this is to build the browser package with only those two languages and look at test.html to see what AspectJ finds in Java snippet that it shouldn't. It's tricky though :-).

However there are a few simpler things to before diving into cross-relevance magic:

  • Please re-indent the code with two space for consistency with the rest of the library.
  • The test snippet should be way, way smaller. The ideal size is just a few lines showing important aspects of the language, it shouldn't be a big chunk of real-world code. Look at Python or C++ for example.
  • You've defined quite a bit of language specific class names ("shortkeys", "aspect", "associations", etc.) but they simply won't be visibly highlighted without styles. Stick to the common class names. In fact, we're going to be more strict about this policy in the future. It's perfectly okay to define parsing modes without class names, especially if they're unique for the language, as they help in language detection.

@ozlerhakan
Copy link
Contributor Author

Thank you very much I will consider all of them :)

@ozlerhakan ozlerhakan closed this Oct 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants