Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new styles #911

Merged
merged 13 commits into from
Sep 15, 2015
Merged

Conversation

Sannis
Copy link
Collaborator

@Sannis Sannis commented Aug 18, 2015

  • fortran
  • irpf90
  • golo
  • kotlin
  • nsis
  • step21
  • tp

@Sannis Sannis added language update style enhancement An enhancement or new feature labels Aug 18, 2015
@Sannis Sannis added this to the 9.0 milestone Aug 18, 2015
@Sannis
Copy link
Collaborator Author

Sannis commented Aug 18, 2015

@isagalaev you can merge this at any moment - I'll just create new branch for next bunch of languages.

@Sannis Sannis changed the title WIP: Update to new styles Update to new styles Aug 18, 2015
@isagalaev
Copy link
Member

Yes, I should be able to look into this today!

@isagalaev
Copy link
Member

I've got one general comment.

I still haven't made my mind about calling built-in types by the "type" class name. This was intended for languages like Haskell and Scala where a type is an important concept and they are mostly user-defined, rather than being just built-in primitive types. So in languages like Java I just stick those with the other keywords.

If this explanation does make sense, let's keep it this way for now. Also kotlin.js has many things called "type" (like stuff between <..> and after : in a function definitions) that should really be class-less.

@Sannis
Copy link
Collaborator Author

Sannis commented Aug 19, 2015

I used to work on such tasks iteratively, so I set a goal to reduce CSS classes number.
But this makes sense, so I'll update this PR with this new concept.

@Sannis
Copy link
Collaborator Author

Sannis commented Sep 5, 2015

@isagalaev what about literals? IMO we can merge them into keywords list. But I have no thoughts about builtints.

@isagalaev
Copy link
Member

The difference between keywords and literals is quite clear: keywords define code structure, literals are just special values, along with numbers and strings. As long as the description is clear I prefer to keep things separate as it is always possible to just color them the same way if needed.

@Sannis
Copy link
Collaborator Author

Sannis commented Sep 12, 2015

@isagalaev, I've merged built-in types into keywords for these languages.

@isagalaev isagalaev merged commit a3901db into highlightjs:new-styles Sep 15, 2015
@Sannis Sannis deleted the new-styles-sannis-1 branch September 15, 2015 21:11
@Sannis
Copy link
Collaborator Author

Sannis commented Sep 15, 2015

Nice!

@isagalaev
Copy link
Member

Only three left now :-) And a bunch of other stuff (docs, cleanup, etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants