Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boost module doesn't seem to remove "tracker" companion path element on "Reset Zoom" #4675

Closed
teeterc opened this issue Oct 21, 2015 · 4 comments
Assignees

Comments

@teeterc
Copy link

teeterc commented Oct 21, 2015

I noticed that the boost module leaves a "highchart-tracker" svg path when the graph is reset. It's completely reproducible on the demo site.

http://www.highcharts.com/component/content/article/2-news/175-highcharts-performance-boost

In Safari (No ghosting in chrome, but the tracker element still lingers):
1: zoom to a range smaller then boostThreshold.
2: zoom to a smaller range that contains only couple hundred points ... notice the ghosting in safari
3: inspect the src svg element <g class="highcharts-series highcharts-series-0 highcharts-tracker" ...> that is created.

note: there are 4 path elements and 1 image element.

4: click on the zoom reset button in the Highchart graph.
5: inspect the svg element <g class="highcharts-series highcharts-series-0 highcharts-tracker" ...>

note: there are now 2 path elements and 1 image element.

Bug: I believe that the second path element - - should be destroyed in the method boost.src.js:destroyGraphics() This artifact (depending on the size of the tracker element) can destroy performance and memory in Safari.

node: depending on the threshold the tracker element can be very large.

Cheers,
Clay

@pawelfus
Copy link
Contributor

Indeed, tracker is not removed after zooming out. I'm not sure about this ghosting effect, could you post screenshot and Safari version? Thanks!

@pawelfus pawelfus self-assigned this Oct 21, 2015
pawelfus added a commit that referenced this issue Oct 21, 2015
@teeterc
Copy link
Author

teeterc commented Oct 21, 2015

Here is a video:
https://www.youtube.com/watch?v=R28Sq-OOrxU&feature=youtu.be

Safari Version 8.0.7 (10600.7.12)

@pawelfus
Copy link
Contributor

Should be fixed on the bugfix branch, could you confirm? See: http://jsfiddle.net/a129eret/8/

@teeterc
Copy link
Author

teeterc commented Oct 23, 2015

Look Great, the ghosting and the tracker remnants are gone. Cheers!

TorsteinHonsi added a commit that referenced this issue Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants