Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging jaxb-basics / jaxb-annotate in this repository #276

Closed
wants to merge 698 commits into from

Conversation

laurentschoelens
Copy link
Collaborator

Process used described here : #264

Final commit handles the merge migration process to make all modules in one single maven build with additional work on jdk17 build failure (on basics / annotate parts) and usage of jaxb-maven-plugin in basics / annotate subprojects.

highsource and others added 30 commits November 29, 2014 15:13
Issue highsource#11. Adding JUnit to compare against the Eclipse generator.
therefore getters/issetter were not generated correctly.
mattrpav and others added 20 commits April 26, 2022 12:27
…n with jaxb-maven-plugin (highsource#169)

Co-authored-by: Laurent SCHOELENS <laurent.schoelens@sfr.com>
…ce#167)

Co-authored-by: Laurent SCHOELENS <laurent.schoelens@sfr.com>
highsourceGH-72 : prepare jakarta migration (and remove .settings files)
@laurentschoelens
Copy link
Collaborator Author

laurentschoelens commented Jul 3, 2023

Only the last commit is interesting to review in my opinion :
567d22a

- usage of jaxb-maven-plugin in basics / annotate projects
- fixing build issues with jdk17 on basics / annotate projects
@laurentschoelens
Copy link
Collaborator Author

Will close this PR when @mattrpav will end up with a more softer approach of this migration 😄
Work in progress

@bertramn
Copy link

bertramn commented Aug 8, 2023

@laurentschoelens and @mattrpav any way we could help with the refactoring? We need to move to JAXB 3 in the next 2 months and happy to discuss migration strategies and contribute. I had a look at the various PRs and it feels like work is getting stuck due to "too big to refactor" situation. Maybe there are some other approaches we could try.

@laurentschoelens
Copy link
Collaborator Author

@laurentschoelens and @mattrpav any way we could help with the refactoring? We need to move to JAXB 3 in the next 2 months and happy to discuss migration strategies and contribute. I had a look at the various PRs and it feels like work is getting stuck due to "too big to refactor" situation. Maybe there are some other approaches we could try.

Hi @bertramn
We are working with @mattrpav in fixing various bugs that are open for a long time now.
When done and refactoring done too, we will move on to jakarta very soon.
If you need to test jaxb3 with jakarta classes, you can use this trick until official release : #233 (comment)
Worked for many people and also used by some collegues.
Tell us if that works for you too.

@bertramn
Copy link

The workaround in #233 would never work for our setup. Yes it changes the generated source files but it leaves all the compilation episodes and schema namespaces produced by XJC broken with old sun links. I guess what could help is a snapshot release of the update progress [1]. This way we could test provide MRs for things not working. @laurentschoelens is there appetite to break this down and have people help get the migration finished?

[1] https://central.sonatype.org/publish/publish-maven/#performing-a-snapshot-deployment

@mattrpav
Copy link
Collaborator

@bertramn the bulk of the merge work is done. This PR is out-dated and is going to be closed. We are working to release v2.0.4 which combines jaxb-maven-plugin and jaxb-basics into 'jaxb-tools'. Once this is done, the jakarta work is straight-forward.

@mattrpav mattrpav closed this Aug 14, 2023
@laurentschoelens laurentschoelens deleted the mjp-264 branch September 12, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants