Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#188] Classloaders not being closed for mojo classloader #353

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

laurentschoelens
Copy link
Collaborator

@laurentschoelens laurentschoelens commented Aug 29, 2023

This will try to close URLClassLoader created by XJCMojo when no more needed to free resources earlier in build.
Fixes #188

Copy link
Collaborator

@mattrpav mattrpav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick fix-- please use try-with-resources pattern instead.

@laurentschoelens
Copy link
Collaborator Author

Review taken into account and forced-pushed.
Please could you review again ?

Copy link
Collaborator

@mattrpav mattrpav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattrpav mattrpav merged commit 393ce87 into highsource:master Sep 1, 2023
3 checks passed
@mattrpav mattrpav deleted the jt-188 branch September 1, 2023 14:11
@mattrpav mattrpav modified the milestones: 2.0.6, 2.0.7 Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Classloaders not being closed for mojo classloaders
2 participants