Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename jaxb2-basics-* modules to jaxb-plugins-* #392

Merged
merged 11 commits into from
Sep 21, 2023
Merged

Conversation

mattrpav
Copy link
Collaborator

No description provided.

@@ -8,7 +8,7 @@ Welcome to the most advanced and feature-full sets of [JAXB](https://github.com/

The project is currently containing the following tools :
* [JAXB Maven Plugin](#jaxb-maven-plugin)
* [JAXB Basics Plugins](#jaxb2-basics)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you want to change the anchor, you'll need to change the title down there from JAXB basics to JAXB Plugins

Copy link
Collaborator

@laurentschoelens laurentschoelens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things to change but will merge as is since main parts are OK

<version>3.0.0-SNAPSHOT</version>
</parent>
<artifactId>jaxb2-basics-test-issues</artifactId>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing plural in jaxb-plugin*s* name

@laurentschoelens laurentschoelens merged commit 757a1fa into master Sep 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants