Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#502] fix for m2e runOnConfiguration will only setupDirectories and no more execute actual XJC #505

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

laurentschoelens
Copy link
Collaborator

Fixes #502

Detect EclipseEmptyBuildContext used in eclipse m2e runOnConfiguration phase and do only setup phase of the plugin

Actual XJC run will then be done in the runOnIncremental phase after the setup phase

@laurentschoelens
Copy link
Collaborator Author

@alerosmile if you want to review 😄

@alerosmile
Copy link

@laurentschoelens : Looks good to me. Thanks a lot. Will this be integrated to v3 and v4 as well?

Just one minor: Rename the configurationPhase to m2eConfigurationPhase.

@laurentschoelens
Copy link
Collaborator Author

Yes it will be integrated in v3 and v4 too 😉

@mattrpav
Copy link
Collaborator

Heads up test failure (possible regression?) in 'po-customized-toplink'

@laurentschoelens
Copy link
Collaborator Author

Heads up test failure (possible regression?) in 'po-customized-toplink'

@mattrpav : this is because it's one of the first PR since v3.
Project po-customized-toplink was missing some property-version in hyperjaxb3-maven-plugin so it's getting the latest version (jakarta-based) and failing.

This was fixed in the first PR regarding jaxb-tools-v2 which is still waiting for review #500 with the following commit

@laurentschoelens
Copy link
Collaborator Author

Rebased to get latest jaxb-tools-2.x updates (this should fix the build error in po-customized-toplink)

@laurentschoelens
Copy link
Collaborator Author

@mattrpav checks are OK as expected 👍

Copy link
Collaborator

@mattrpav mattrpav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattrpav mattrpav merged commit 77dc697 into highsource:jaxb-tools-2.x Feb 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants