[#508] add test project for fluent-api plugin #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentschoelens
force-pushed
the
jt-508
branch
from
94b3138
to
e2ad412
Compare
mattrpav
requested changes
Feb 20, 2024
There was a problem hiding this comment.
A couple changes requested:
- Add an attribute for each primitive type -- boolean, long, float, etc -- to confirm the builder handles all the types correctly.
- Add a collection of something to ensure collections work as expected
- Add tests to verify the 'getter' for the above
laurentschoelens
force-pushed
the
jt-508
branch
from
e2ad412
to
bdb9598
Compare
laurentschoelens
force-pushed
the
jt-508
branch
from
bdb9598
to
516be1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test case for fluent-api XJC plugin