Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2 Beta Feedback #26

Open
highvolt-dev opened this issue Dec 30, 2021 · 9 comments · Fixed by #23, #24, #30, #33 or #36
Open

Version 2 Beta Feedback #26

highvolt-dev opened this issue Dec 30, 2021 · 9 comments · Fixed by #23, #24, #30, #33 or #36
Labels
help wanted Extra attention is needed

Comments

@highvolt-dev
Copy link
Owner

Substantial work from @AndrewPardoe has lead to a new upcoming major version release, 2.0. This issue is intended to track any feedback regarding this release.

Specifically:

  • .env file and configuration override nuances
  • logging behavior
  • ping behavior (the ping implementation was slightly changed when extracting latency information for logging) - need to confirm that no regressions are introduced, particularly with Windows in the case of a "Network not reachable" edge case.
@highvolt-dev highvolt-dev added the help wanted Extra attention is needed label Dec 30, 2021
@highvolt-dev highvolt-dev pinned this issue Dec 30, 2021
@highvolt-dev highvolt-dev reopened this Dec 30, 2021
@highvolt-dev highvolt-dev linked a pull request Dec 31, 2021 that will close this issue
@highvolt-dev
Copy link
Owner Author

#31 logging regression

@highvolt-dev
Copy link
Owner Author

#32 seemed to introduce unnecessary dependencies in #23

@highvolt-dev
Copy link
Owner Author

Incorporated latest fixes into pre-release https://github.com/highvolt-dev/tmo-monitor/releases/tag/v2.0.0-beta2

@highvolt-dev
Copy link
Owner Author

#34 needed to specify reboot on ping with .env - now possible to strictly use cli flags again

@highvolt-dev
Copy link
Owner Author

Restructured project in #47

Python's setuptools will now make tmo-monitor.py accessible in your path. Updated documentation.

Added support for Arcadyan gateway.

@highvolt-dev
Copy link
Owner Author

Beta 3 release needed tmo_monitor.gateway module to be listed in setup.py, fixed by #51

@highvolt-dev
Copy link
Owner Author

@hugoh added #54 in #55
Need testers for OS X
Need to add Windows event logging
Need to add to README

@highvolt-dev
Copy link
Owner Author

capture_output kwarg for subprocess.run in call to ping causes Python 3.6 compatibility issues.

@highvolt-dev
Copy link
Owner Author

Nokia firmware version 1.2103.00.0338 introduced changes to the authenticated web application endpoints. Fixed in #57 which is released in https://github.com/highvolt-dev/tmo-monitor/releases/tag/v2.0.0-beta4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment