Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address the feedback from #24 #30

Merged
merged 2 commits into from
Dec 31, 2021
Merged

Address the feedback from #24 #30

merged 2 commits into from
Dec 31, 2021

Conversation

AndrewPardoe
Copy link
Contributor

  1. Add back ping failure check on Windows
  2. Add logging options on command line
  3. Add missing options to README
  4. Add print_and_log helper function

@AndrewPardoe
Address feedback in highvolt-dev#24
0fb19cb 
Squashed commit of the following:

commit b1a388c4364ddf5998c93d431c8bd77c367680d9
Author: Andrew Pardoe <AndrewPardoe@users.noreply.github.com>
Date:   Fri Dec 31 09:50:27 2021 -0800

    Add print_and_log function

commit fe673487bde3ca3768a67ef633bc09595b95f6d3
Author: Andrew Pardoe <AndrewPardoe@users.noreply.github.com>
Date:   Fri Dec 31 09:21:29 2021 -0800

    Add logging options to command line & README

    Also add back early ping success check for Windows.
@AndrewPardoe
NFC
8261a49
@AndrewPardoe AndrewPardoe mentioned this pull request Dec 31, 2021
Closed
highvolt-dev
highvolt-dev approved these changes Dec 31, 2021
View reviewed changes
Copy link
Owner

@highvolt-dev highvolt-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you as always - this looks perfect.

@highvolt-dev highvolt-dev merged commit 04b15a1 into highvolt-dev:main Dec 31, 2021
@highvolt-dev highvolt-dev mentioned this pull request Dec 31, 2021
Closed
@highvolt-dev highvolt-dev linked an issue Dec 31, 2021 that may be closed by this pull request
Version 2 Beta Feedback #26
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@highvolt-dev highvolt-dev highvolt-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version 2 Beta Feedback
2 participants
@AndrewPardoe @highvolt-dev