Calculate the np.nan array on the fly of not available #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. It's fast enough 2. Otherwise one is forced to provide `not_nan_array` to get normalization, which is confusing as the doc string doesn't mention that and no normalization seems odd
pkerpedjiev
reviewed
Jul 5, 2019
|
Added #102 regarding the test! Will try to get that done asap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For
npvector, calculate thenp.nanarray on the fly of not available.This simplifies the code the user has to write. Also:
not_nan_arrayto get normalization. Before it was confusing as the docstring doesn't mention normalization and no normalization seems an odd behavior.Checklist
[ ] Unit tests added or updated