Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of test.sh #33

Open
mccalluc opened this issue Mar 1, 2017 · 2 comments
Open

get rid of test.sh #33

mccalluc opened this issue Mar 1, 2017 · 2 comments

Comments

@mccalluc
Copy link
Collaborator

mccalluc commented Mar 1, 2017

Different tests have different setup requirements. End goal is to only have python tests and call them via manage.

@flekschas
Copy link
Member

Can manage download files for you? I think this is the main reason for having test.sh no?

@mccalluc
Copy link
Collaborator Author

I'm not totally against a shell wrapper for tests, particularly if there are different kinds of tests, ie, unit tests + linting + building a package, but we've only got one test run here, and the rest is setup.

I think I was imagining that the tests would have setup methods that would download the files they need. By having this nearby, it's more clear what each test needs in order to run, and it also makes it easier to use the other command-line options on the test runner.

It's sort of like global variables: If something goes wrong, it's harder to track down what should have established the state we wanted.

(But obviously this isn't critical.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants