feat: add efk for log collection #113
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
CraigMChen
force-pushed
the
feat/efk-chart
branch
from
4166b7f
to
9d3f064
Compare
CH3CHO
requested changes
Feb 25, 2023
helm/templates/elasticsearch.yaml
Outdated
| spec: | ||
| containers: | ||
| - name: elasticsearch | ||
| image: docker.elastic.co/elasticsearch/elasticsearch:7.17.0 |
There was a problem hiding this comment.
I think we should allow user to change versions when installing.
helm/values.yaml
Outdated
| memory: 256Mi | ||
| volumeClaim: | ||
| accessMode: ReadWriteOnce |
There was a problem hiding this comment.
If the K8s cluster have multiple nodes, should we use ReadWriteOnce or ReadWriteMany?
helm/values.yaml
Outdated
| es: | ||
| host: elasticsearch.{{ .Values.elasticsearch.namespace }} | ||
| port: 9200 |
There was a problem hiding this comment.
It looks like this value is never used.
|
@CraigMChen Hello, Is there any progress on this work? Could you resolve the conflicts first? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
add efk for log collection
Ⅱ. Does this pull request fix one issue?
fixes alibaba/higress#43