feat: add securityContext for o11y.prometheus #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
CH3CHO
reviewed
Feb 25, 2024
helm/values.yaml
Outdated
| @@ -80,6 +80,9 @@ o11y: | |||
| limits: | |||
| cpu: 500m | |||
| memory: 2Gi | |||
|
|
|||
| securityContext: | |||
There was a problem hiding this comment.
这里感觉直接让用户传入一个对象就好了，是不是不用卡太死？
There was a problem hiding this comment.
have changed, thanks for your advice
o11y:
prometheus:
securityContext: {} securityContext:
{{- toYaml .Values.o11y.prometheus.securityContext | nindent 8 }}
CH3CHO
approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…alibaba/higress/issues/727 fix #289
Ⅰ. Describe what this PR did
fix alibaba/higress#727
fix #289
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews