Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Suppress the exception log when git.properties doesn't exist #291

Merged
merged 1 commit into from Feb 26, 2024
Merged

feat: Suppress the exception log when git.properties doesn't exist #291

merged 1 commit into from Feb 26, 2024

Conversation

CH3CHO
Copy link
Collaborator

@CH3CHO CH3CHO commented Feb 26, 2024

Ⅰ. Describe what this PR did

Suppress the exception log when git.properties doesn't exist.

6acb08e8d09be936da43c9212cbf500d

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

johnlanni
johnlanni approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit eeccc86 into higress-group:main Feb 26, 2024
3 checks passed
@CH3CHO CH3CHO deleted the fix/git-properties-npe branch February 26, 2024 07:15
slievrly
slievrly reviewed Feb 26, 2024
View reviewed changes
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/higress-group/higress-console/blob/main/backend/console/src/main/java/com/alibaba/higress/console/service/SystemServiceImpl.java#L79

if commit == UNKNOWN ? fullVersion += "-dev" : fullVersion += "-" + COMMIT_ID;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slievrly slievrly slievrly left review comments

@johnlanni johnlanni johnlanni approved these changes

@xiangxiuhui xiangxiuhui Awaiting requested review from xiangxiuhui

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CH3CHO @johnlanni @slievrly