Enable providing mqtt login details via the environment #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Environment variables override config variables, if they exist
Describe how to supply MQTT username and password via environment variables.
genkobar
referenced
this pull request
in Momeno/mqtt2prometheus
Sep 20, 2021
Environment variables override config variables, if they exist
|
Thank you 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to provide a username and password for the MQTT broker via the environment instead of the configuration file.
If the environment variables
MQTT2PROM_MQTT_USERandMQTT2PROM_MQTT_PASSWORDexist and are not empty, they will override those parameters in the configuration file.This is especially helpful when trying to avoid leaking application secrets via a version control system.