Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug found in LM-videodownloader The application crashes when I try to rename any file during the download #49

Closed
saraji-ali opened this issue May 6, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@saraji-ali
Copy link

Project Information

Expected behavior

The file name should be changed when I try to rename any file during the download

Actual behavior

The application crashes when I try to rename any file during the download

How to reproduce

1-Download the app and open it
2- Click on the YouTube icon so you will go to YouTube
3-Then apply any video or audio to download
4-Click the 3 verticals line on the top left
5- click on downloads
6- select the In Progress tab and click on the edit icon
7-and now click on ok button
8- see bug

  • Browser/App version: v1.0.1
  • Operating system: 6.0.1
  • Smartphone: Galaxy j7

Recording Of The Bug

20190506_130010

My Github Account

https://github.com/facebook-786

Logcat

E/AndroidRuntime(11523): FATAL EXCEPTION: main

E/AndroidRuntime(11523): Process: marabillas.loremar.lmvideodownloader, PID: 11523

E/AndroidRuntime(11523): java.lang.ArrayIndexOutOfBoundsException: length=12; index=-1

E/AndroidRuntime(11523): 	at java.util.ArrayList.get(ArrayList.java:310)

E/AndroidRuntime(11523): 	at marabillas.loremar.lmvideodownloader.download_feature.lists.DownloadQueues.renameItem(DownloadQueues.java:179)

E/AndroidRuntime(11523): 	at marabillas.loremar.lmvideodownloader.download_feature.fragments.DownloadsInProgress$DownloadItem$2$1.onOK(DownloadsInProgress.java:466)

E/AndroidRuntime(11523): 	at marabillas.loremar.lmvideodownloader.utils.RenameDialog.onClick(RenameDialog.java:56)

E/AndroidRuntime(11523): 	at com.android.internal.app.AlertController$ButtonHandler.handleMessage(AlertController.java:166)

E/AndroidRuntime(11523): 	at android.os.Handler.dispatchMessage(Handler.java:102)

E/AndroidRuntime(11523): 	at android.os.Looper.loop(Looper.java:135)

E/AndroidRuntime(11523): 	at android.app.ActivityThread.main(ActivityThread.java:5910)

E/AndroidRuntime(11523): 	at java.lang.reflect.Method.invoke(Native Method)

E/AndroidRuntime(11523): 	at java.lang.reflect.Method.invoke(Method.java:372)

E/AndroidRuntime(11523): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1405)

E/AndroidRuntime(11523): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1200)
@hikikomoriphoenix
Copy link
Owner

Fixed it.
New APK Here.

Also see the following commits:
8f132f8
af32e8f

@hikikomoriphoenix hikikomoriphoenix added the bug Something isn't working label May 6, 2019
@saraji-ali
Copy link
Author

thanks, sir

Repository owner locked as resolved and limited conversation to collaborators May 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants