Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cbor-web dist is broken #149

Closed
cheweytoo opened this issue Jul 31, 2021 · 4 comments
Closed

cbor-web dist is broken #149

cheweytoo opened this issue Jul 31, 2021 · 4 comments

Comments

@cheweytoo
Copy link

Both https://unpkg.com/cbor-web and .../cbor-web/dist/cbor.js from this repo (which are currently identical) do not work:
Loading them in a web browser (tested in Firefox 90.0.2 and Edge 92.0.902.55) leads to

TypeError: r(...) is undefined
    327 ./cbor.js:2
    o ./cbor.js:2
    481 ./cbor.js:2
    o ./cbor.js:2
    830 ./cbor.js:2
    o ./cbor.js:2
    20 ./cbor.js:2
    o ./cbor.js:2
    141 ./cbor.js:2
    o ./cbor.js:2
    <anonymous> ./cbor.js:2
    <anonymous> ./cbor.js:2
    <anonymous> ./cbor.js:2
    <anonymous> ./cbor.js:2
    <anonymous> ./cbor.js:2
cbor.js:2:155165

and therefore of course also to no cbor object in the browser context.

@cheweytoo
Copy link
Author

cheweytoo commented Aug 1, 2021

Ah, the dist file from branch node12required works.

Leaving this issue open for visibility in case someone else encounters this. Feel free to close it though.

@hildjj
Copy link
Owner

hildjj commented Aug 2, 2021

I'm working toward a v8.0.0 release from that branch right now. I'll leave this open until that ships.

This was likely an issue with bignumber.js support, which I've removed to a plugin for v8.0.0.

@hildjj hildjj closed this as completed in 86696c1 Aug 4, 2021
@hildjj
Copy link
Owner

hildjj commented Aug 4, 2021

Please retest with v8.0.0 and reopen if this isn't fixed.

@cheweytoo
Copy link
Author

Just tested: It works.

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants