Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Preserve YAML Comments #18

Open
datocrats-org opened this issue Jul 1, 2020 · 2 comments
Open

Feature Request - Preserve YAML Comments #18

datocrats-org opened this issue Jul 1, 2020 · 2 comments
Labels
feature help wanted Extra attention is needed

Comments

@datocrats-org
Copy link

It would be nice to have a way to preserve yaml comments perhaps invisibly cache them to a .yamljsoncache file whenever converting from yaml to json, so that when converting back the same element position before or after an element can receive the comment. There may not be anything on npm that does this, granted, and the method of either adding the comment to the element, when converting to json also keep an extension with .jsonc or something indicating comment support and including it inline // or multi-line /* */

@hilleer hilleer added enhancement New feature or request feature labels Jul 1, 2020
@hilleer
Copy link
Owner

hilleer commented Jul 2, 2020

Interesting idea @datocrats-org.

I see some initial issues in relation to saving a cache of the file and re-adding the comments, but will have a deeper look into it and see what is possible and makes most sense and then get back to you :-)

@iWangJiaxiang
Copy link

It would be nice to support JSON comment (jsonc)

@hilleer hilleer added help wanted Extra attention is needed and removed enhancement New feature or request labels Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants