Move .REVIEW_COMMENT_STATE to .git #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chitoku-k
commented
Oct 22, 2020
|
|
||
| let l:pr = split(system([s:script_dir . 'pr-id.sh', trim(l:owner), trim(l:name), trim(l:current_branch)]), "\n") | ||
|
|
||
| let l:pr = systemlist([s:script_dir . 'pr-id.sh', l:owner, l:name, l:current_branch]) |
There was a problem hiding this comment.
systemlist を使えば split 不要できれいになる
| @@ -33,12 +28,17 @@ endfunction | |||
| function! g:goshiteki#add_review_comment() range abort | |||
| let s:add_review_comment_tempname = tempname() | |||
| let s:git_root = trim(system(['git', 'rev-parse', '--show-toplevel'])) . '/' | |||
| let s:git_dir = getenv('GIT_DIR') | |||
There was a problem hiding this comment.
GIT_DIR 対策がちょっと入ってしまった
There was a problem hiding this comment.
Suggested change
| let s:git_dir = getenv('GIT_DIR') | |
| let s:git_dir = getenv('GIT_DIR') || '.git' |
を使うと一撃でやりたいことできそうで、下のifがいらない気がする?
There was a problem hiding this comment.
Vim script は || の結果が整数型になるのでそれは NG
| @@ -68,8 +67,8 @@ endfunction | |||
|
|
|||
| function! g:goshiteki#post_submit(status, tempname, pr_id) abort | |||
| let l:body = join(readfile(a:tempname), "\n") | |||
| call system([s:script_dir . 'submit-review.sh', a:pr_id, l:body, a:status, "./.REVIEW_COMMENT_STATE"]) | |||
| echo "Submit review(status: " . "a:status" . ")" | |||
| call system([s:script_dir . 'submit-review.sh', a:pr_id, l:body, a:status, s:git_root . s:git_dir . '/REVIEW_COMMENT_STATE']) | |||
There was a problem hiding this comment.
.git の中なので . 始まりのファイル名もやめた
chitoku-k
commented
Oct 22, 2020
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| # review-comments readme.md 1 body json | |||
| review-comments() { | |||
| local REVIEW_COMMENT_STATE="./.REVIEW_COMMENT_STATE" | |||
| local REVIEW_COMMENT_STATE=$(git rev-parse --show-toplevel)/${GIT_DIR:-.git}/REVIEW_COMMENT_STATE | |||
There was a problem hiding this comment.
シェルスクリプト側は一行で書ける
chitoku-k
commented
Nov 13, 2020
himanoa
approved these changes
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REVIEW_COMMENT_STATEを.git以下に移動（fix Goshiteki のステートがカレントディレクトリーに置かれている #23）\nを使っている箇所以外はシングルクォートに統一systemlistへの置き換えで読みやすく