Skip to content
This repository has been archived by the owner on Jan 2, 2023. It is now read-only.

prototype home #81

Closed
wants to merge 1 commit into from
Closed

Conversation

nisha331
Copy link

Description

This is a prototype of the home page , all dummy texts and images are used . It is made using html CSS and bootstrap.

issue #5 #58

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #5 #58

created the page from scratch.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

ATTACH SCREEN-SHOTS

Screen recording - https://drive.google.com/file/d/1aIyJVEetfyE56RtGYUDVBV5StgLLnowg/view?usp=drivesdk
Capture6
Capture7
Capture4
Capture3
Capture1
Capture
Capture1

@nisha331
Copy link
Author

what is progress on the PR?

@1502shivam-singh
Copy link

@nisha331 sorry for the delayed response.
This prototype needs some more work, firstly

img
In this one the hierarchy and contrast is a problem. The hero text is too dim to be visible against the colorful image background. Try to keep an image similar to one you will actually want in the website if thinking for a placeholder image for now.
Try raising the font weight and size for proper hierarchy and clarity. check this for explanation on visual hierarchy
Also, the background image doesn't have much correlation with charity or saving lives per se.

And in the "about us" kind of section where you mention what we do etc. try to keep it center aligned rather than left, as you have followed this in other sections too, testimonials for example, just for consistency.

@nisha331
Copy link
Author

@1502shivam-singh , thanks for your response , for the hero text i can definitely do it but the thing s that that image use is just from google when we will put the image that the org will provide , we again would have to adjust it, so in my opinion we can adjust it at that time rather then doing the same thing twice .
And regarding the about us section , according to me its the home page so adding few img of the org will look good(though its my personal opinion). I can bring it to center no issue but it would become a bit dull.

This were the points i had to put forward now, if you still want changes you are welcome , just look into the points and say me the changes to be done.

Thanking You
Nisha

@1502shivam-singh
Copy link

@1502shivam-singh , thanks for your response , for the hero text i can definitely do it but the thing s that that image use is just from google when we will put the image that the org will provide , we again would have to adjust it, so in my opinion we can adjust it at that time rather then doing the same thing twice .
And regarding the about us section , according to me its the home page so adding few img of the org will look good(though its my personal opinion). I can bring it to center no issue but it would become a bit dull.

This were the points i had to put forward now, if you still want changes you are welcome , just look into the points and say me the changes to be done.

Thanking You
Nisha

That's what I am saying here for the hero section. Put an image that is close to what you would actually put in the hero section, or don't put an image for now, just a color as placeholder for now. This is because, you are providing a prototype here, and I expect the prototype to be what will actually come on the website. What you have done here is mixed "Wireframe" with "Prototype".
If you are not clear on hero image for now, put an image that is close to what you will put or as above I suggested.
For the hero text, do look into it in terms of hierarchy and clarity(accessibility).

And how exactly would centering the elements here make it look dull? To be clear, I mean centering individual elements
image

For example this -
image

And just a suggestion, try to work more on visual design, to improve UX of the website from 10x to 100x. If you need some website suggestions for design inspiration, do ask.

@1502shivam-singh
Copy link

I am not sure whether org would provide a hero image, so maybe try a dull photo for now, rather than something bright and colorful.

@nisha331 nisha331 closed this Jun 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Home page
3 participants