Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include capitalised versions of environment variables #22

Closed
skulltech opened this issue Jun 3, 2017 · 5 comments
Closed

Include capitalised versions of environment variables #22

skulltech opened this issue Jun 3, 2017 · 5 comments

Comments

@skulltech
Copy link
Contributor

Some programs check for the HTTP_PROXY, HTTPS_PROXY and environment variables like this instead of the usual lowercase ones. One example I could give right now is the Ruby package manager gem (see this stackoverflow answer).

@himanshub16
Copy link
Owner

I've merged this PR. But the changes should be made to bash.sh as well.

@himanshub16 himanshub16 reopened this Jun 3, 2017
@himanshub16
Copy link
Owner

himanshub16 commented Jun 3, 2017

I would recommend having capitalised variables as aliases to small case variables.
For example,

HTTP_PROXY=$http_proxy

If you are going this way, then it would require you to modify the environment.sh file as well

@skulltech
Copy link
Contributor Author

Good call about editing bash.sh. And using aliases are also neat, that could be done. Opening the previous pull request to continue on this would've been nice, but I'm not entirely sure if that can be done or not.

@skulltech
Copy link
Contributor Author

I did not implemented aliases like you recommended, cause that may make the intention of the program unclear. We are trying to export two separate environment variables HTTP_PROXY and http_proxy, so I think exporting them normally would be better.

@skulltech
Copy link
Contributor Author

@himanshub16 Pull request #25 fixes this. Let me know if there are any problem and I'll push more commits ( if there are any problem ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants