Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added environment.sh #67

Closed
wants to merge 1 commit into from
Closed

added environment.sh #67

wants to merge 1 commit into from

Conversation

tuxfy
Copy link
Contributor

@tuxfy tuxfy commented Jan 22, 2019

No description provided.

@himanshub16
Copy link
Owner

This can be handled from shellrc.sh.
Please see how bash-zsh.sh works.

Also, I wanted to avoid handling /etc/environment due to #45

@tuxfy
Copy link
Contributor Author

tuxfy commented Jan 23, 2019

OK, I understand.
But you have the option in the targets list but no file for execution.

@himanshub16
Copy link
Owner

Yes. That was intentional, but having the same content here causes redundant code.

So yeah, it would be better if we can have an entry (intentionally commented out) in bash-zsh.sh or a file environment.sh with the same content as bash-zsh.

@tuxfy
Copy link
Contributor Author

tuxfy commented Jan 23, 2019

Maybe something like this

  1. do_all without environment
  2. do_all with environment (REBOOT REQUIRED)
  3. terminal
  4. ...
  5. environment (REBOOT REQUIRED)

@himanshub16
Copy link
Owner

Okay. But why would one need proxy settings in /etc/environment?
Wouldn't Default env_keep += "http_proxy" in /etc/sudoers work?

The hesitation behind using /etc/environment is the requirement of log-out required to reload it.

@tuxfy
Copy link
Contributor Author

tuxfy commented Jan 24, 2019

For example:
https://forum.snapcraft.io/t/set-snapd-proxy-via-core-configuration/467/20
But, I testing the alternative way /etc/systemd/system/snapd.service.d/proxy.conf -> WORKING
pull request #72

@tuxfy tuxfy closed this Jan 31, 2019
@tuxfy tuxfy deleted the patch-5 branch January 31, 2019 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants