-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark Theme toggle #12
Comments
I will do this @himanshusharma89. |
Okay @arbazdiwan, assigning it to you. Create the toggle in the Drawer. |
are you want add dark mode with toogle button? has this issue been worked out? |
@daruanugerah This issue is assigned to @arbazdiwan. And @arbazdiwan If you are facing an issue or cannot create a PR, comment here, I'll assign it to @daruanugerah. Also @daruanugerah you can create issues if you find some error or you want a feature in this project. |
I am working on it. will open a PR tomorrow.
…On Fri, 2 Oct 2020, 6:30 pm HIMANSHU SHARMA, ***@***.***> wrote:
@daruanugerah <https://github.com/daruanugerah> This issue is assigned to
@arbazdiwan <https://github.com/arbazdiwan>. And @arbazdiwan
<https://github.com/arbazdiwan> If you are facing an issue or cannot
create a PR, comment here, I'll assign it to @daruanugerah
<https://github.com/daruanugerah>. Also @daruanugerah
<https://github.com/daruanugerah> you can create issues if you find some
error or you want a feature in this project.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#12 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF5PZSEQ5ZGQ7VDMVAJTGOTSIXFFJANCNFSM4SBF6XEA>
.
|
ok
…On Fri, Oct 2, 2020 at 11:02 AM HIMANSHU SHARMA ***@***.***> wrote:
Okay @arbazdiwan <https://github.com/arbazdiwan>, assigning it to you.
Create the toggle in the Drawer.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#12 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF5PZSGHB3OSFBC3ARTVJATSIVQW7ANCNFSM4SBF6XEA>
.
|
Hello @himanshusharma89 ,
I have created PR.
I just went through the app to test the functionality. The add post functionality does not seem to be working.
However, I haven't touched anything (in existing functionality) except adding the toggle-darkmode functionality.
Looking forward to working with you more.
Thanking you,
Arbaz Diwan
|
I resolved all the conflicts. waiting for your review @himanshusharma89 |
1 similar comment
I resolved all the conflicts. waiting for your review @himanshusharma89 |
You can create an issue and work on it. ANd I have updated your PR have a look into it. |
No description provided.
The text was updated successfully, but these errors were encountered: