Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cart System Implemented #260

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Cart System Implemented #260

wants to merge 9 commits into from

Conversation

Atharv-Joshi
Copy link
Contributor

@Atharv-Joshi Atharv-Joshi commented Nov 22, 2021 •
edited
Loading

Related Issue

Closes #248

Proposed Changes

  • User can add items into the cart by clicking on add to cart button on product detail page
  • User can increase/decrease the quantity of items in the cart
  • User can delete an item from the cart
  • shimmer effect added while data is loading

Known Issues

  • Price in payment window hardcoded

Checklist

  • Tested
  • No Conflicts
  • Change In Code
  • Change In Documentation
  • Follows linting rules

Screenshots

cart system
shimmer

@Atharv-Joshi
inverted visibility icons in login signup as they are logically corre…
cc460ec 
…ct , added color theme for icons, relevant variable names, back button to login page from signup page
@Atharv-Joshi
Revert "inverted visibility icons in login signup as they are logical…
603b877 
…ly correct , added color theme for icons, relevant variable names, back button to login page from signup page"

This reverts commit cc460ec.
@Atharv-Joshi
password visibilty icons reversed , login button on sigup page , fit …
9a7d3ba 
…type to cover

password visibility icons reversed on login form and sign up form , app theme added to these icons
link to go back to login page added on  signup form
BoxFit.cover added to user photo on get user details
@Atharv-Joshi
Merge branch 'himanshusharma89:master' into master
dd220c4
@Atharv-Joshi
cart system , delete button configured
9a2c93c
@Atharv-Joshi
item amount updates depending on the selected quantity
c51e61b
@Atharv-Joshi
added shimmer effect in cart list
21fee40
@Atharv-Joshi
hardcoded payment values , added const to constructors
017865e
@welcome
Copy link

welcome bot commented Nov 22, 2021

Hello there!👋 Welcome to the project!💖
Thank you and congrats🎉 for opening your first pull request. Please make sure you have gone through our Code of Conduct and contributing files before making this pr. 🙌🙌 We will get back to you as soon as we can 😄.

@himanshusharma89
Copy link
Owner

Hi @Atharv-Joshi, can you tell me how dis you choose get over other state management tools?

@Atharv-Joshi
Copy link
Contributor Author

Hi @Atharv-Joshi, can you tell me how dis you choose get over other state management tools?

actually i was just trying out getx here and forgot to delete that code in pr
I chose getx as its lightweight
I've added a commit which removes all getx related code and follows type annotations where mentioned

@Atharv-Joshi
Copy link
Contributor Author

I'll also add the price in payment window in this PR itself.

@himanshusharma89
Copy link
Owner

Sure @Atharv-Joshi, just tag me when done, because GitHub notifications got skipped from my inbox earlier.

@Atharv-Joshi
Copy link
Contributor Author

sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding the cart system.
2 participants
@Atharv-Joshi @himanshusharma89