Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gtk2 gtk3 immodule 無法在含空白字元之路徑中正常建構 #539

Closed
Vdragon opened this issue Jan 15, 2016 · 4 comments
Closed

gtk2 gtk3 immodule 無法在含空白字元之路徑中正常建構 #539

Vdragon opened this issue Jan 15, 2016 · 4 comments

Comments

@Vdragon
Copy link
Contributor

Vdragon commented Jan 15, 2016

如題，修正產生中……
Vdragon pushed a commit to Vdragon/hime that referenced this issue Jan 15, 2016
@brlin-tw
build system - Fix won't build in path with spaces(gtk2/gtk3 support), …
24cdb01 
…fixes hime-ime#539

Currently build will fail if your path contains space, this patch deals
with the issue by quoting destination paths in under the "install" make
targets.

Note that this patch doesn't deal with all Makefiles and need further
patch & review.

Signed-off-by: Ｖ字龍(Vdragon) <Vdragon.Taiwan@gmail.com>
Vdragon pushed a commit to Vdragon/hime that referenced this issue Jan 15, 2016
@brlin-tw @Vdragon
build system - Fix won't build in path with spaces(gtk2/gtk3 support), …
42e3b5e 
…fixes hime-ime#539

Currently build will fail if your path contains space, this patch deals
with the issue by quoting destination paths in under the "install" make
targets.

Note that this patch doesn't deal with all Makefiles and need further
patch & review.

Signed-off-by: Ｖ字龍(Vdragon) <Vdragon.Taiwan@gmail.com>
Vdragon added a commit to Vdragon/hime that referenced this issue Jan 15, 2016
@Vdragon
build system - Fix won't build in path with spaces(gtk2/gtk3 support), …
44f58b0 
…fixes hime-ime#539

Currently build will fail if your path contains space, this patch deals
with the issue by quoting destination paths in under the "install" make
targets.

Note that this patch doesn't deal with all Makefiles and need further
patch & review.

Signed-off-by: Ｖ字龍 <Vdragon.Taiwan@gmail.com>
@Vdragon Vdragon mentioned this issue Jan 15, 2016
Merged
@favonia
Copy link
Contributor

favonia commented May 24, 2016

和 #520 基本上是同樣的問題（路徑沒有加引號）。

@favonia favonia closed this as completed May 24, 2016
@Vdragon
Copy link
Contributor Author

Vdragon commented May 25, 2016

@favonia #520 的修正已經合併至 master 分支，這個的目前還沒
雖然的確是同一個問題

@Vdragon
Copy link
Contributor Author

Vdragon commented May 25, 2016

個人認為應該是關 #520 開這個

@favonia
Copy link
Contributor

favonia commented May 25, 2016

@Vdragon 也許我誤解了，但我以為 #520（無法編譯）還沒有完全修正。實際上 #539（gtk 不能編譯）的存在正代表了 #520（不能編譯）還沒解決。我覺得直到所有路徑都有引號後，#520 才算結束，我個人覺得有多個 pull requests 指向 #520 也無所謂。

我最在乎的是不要有明顯重複的 issue。我猜測你希望一個 pull request 對應到一個 issue。到底要開哪一個我不那麼在乎，要開就開吧 😎

Tetralet added a commit that referenced this issue Jul 6, 2016
@Tetralet
Merge pull request #541 from Vdragon/patch-issue-539
3f52703 
build system - Fix won't build in path with spaces(gtk2/gtk3 support), fixes #539
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Vdragon @favonia