add support for http-conduit-2.3 and conduit-1.3 #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't actually tried compiling this PR with older versions of GHC/http-conduit/conduit yet. I'll do that tomorrow. Also, if the CI tests fail I'll try to figure out why. |
It is actually API change in http-conduit that is affecting us. This change should allow twitter-conduit to continue compiling on ghc-7.10 and ghc-7.8. This should fix the travis failure.
|
Okay, it looks like with commit 798e90d, everything should be building successfully. This PR should be ready for review. |
|
It looks great! Thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for both http-conduit-2.3 and conduit-1.3.
At work we are trying to use twitter-conduit with stackage's lts-11, which includes http-conduit-2.3 and conduit-1.3. Once this gets merged it, it would be great if you could cut a release!
It seems like there are quite a few changes in conduit-1.3.
ResumableSourcehas been removed, so now some of the http-conduit functions just return a normalSourceinstead. (Also,Sourcehas been deprecated, and the conduit docs say to use the fullConduitTtype.) Now some of the functions in this package are returning aConduitTinstead of aResumableSource.Also, there was a problem with using
MonadBase IO. To be honest, I'm not sure what the problem was. I think some type has lost aMonadBaseinstance, but I didn't really look into what has happened. Instead, I just switched everything to usingMonadIO. I don't think there should be a problem with this, but if there is, let me know.I think the Snoyman-family of libraries have been moving away from
MonadBaseandMonadBaseControland instead settling onMonadIOandUnliftIO. I thought this might be the reason for theMonadBase IOproblem, but like I said, I didn't look into it.I also modified the travis.yml file to test on ghc-8.4.3.
This PR would require a major version bump before being released to Hackage.